Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -d:nimNoGetEntropy to allow running on macOS earlier than 10.12 #20460

Closed
wants to merge 1 commit into from

Conversation

iffy
Copy link
Contributor

@iffy iffy commented Sep 29, 2022

Related to #17370 but not the same. This change enables me to compile on a newer macOS a program that runs on an older macOS.

This does not restore the ability to compile on older macOS.

@Araq
Copy link
Member

Araq commented Sep 29, 2022

Why nimNoGetEntropy? Why not e.g. nimOldOsX?

@iffy
Copy link
Contributor Author

iffy commented Sep 29, 2022

Why nimNoGetEntropy? Why not e.g. nimOldOsX?

I was trying to match nimNoGetRandom (which is adjacent to this) and be specific to this feature rather than possibly conflicting with a more general thing. I could imagine there being nimOldOsX now and nimSlightlyNewerOldOsX later :) Ideally, I'd rather make the code just work for old and new, but that would require doing a runtime check rather than a compile-time check and I don't know how to do that.

@iffy
Copy link
Contributor Author

iffy commented Sep 29, 2022

Wait, I've got some idea how I could do it with dynlib. Let me try again.

@iffy
Copy link
Contributor Author

iffy commented Oct 4, 2022

Okay #20466 is the better fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants