Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move dollars out of system #20185

Closed
wants to merge 7 commits into from
Closed

move dollars out of system #20185

wants to merge 7 commits into from

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Aug 9, 2022

  • the compiler keeps bootstrapping with -d:nimPreviewSlimSystem
  • the std/dollars uses new float algorithm when -d:nimPreviewSlimSystem is enabled, otherwise you can still switch them on/off by nimPreviewFloatRoundtrip

@ringabout
Copy link
Member Author

ringabout commented Aug 10, 2022

ref #19388
ref nim-lang/RFCs#437

@ringabout ringabout mentioned this pull request Aug 10, 2022
33 tasks
@metagn
Copy link
Collaborator

metagn commented Aug 10, 2022

Was this discussed previously? Doesn't echo need $?

Edit: Apparently it was discussed in #19388 but just for floats. dollars has way more than that, plus addFloat is still included in system here, so compilation time isn't saved. I think this is an overly dramatic thing to do just to enable roundtrip float-string conversion. If it was for the sake of separating $, then I would understand it, but $ is deeply integrated in a lot of Nim code so it's not going to be easy to just casually do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants