only allow enums to overload enums + extra test #20126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirror behavior without overloadableEnums
|
Updated description to explain what the PR does |
|
Thanks for your hard work on this PR! Hint: mm: orc; threads: on; opt: speed; options: -d:release |
metagn
added a commit
to metagn/Nim
that referenced
this pull request
Sep 3, 2022
Araq
pushed a commit
that referenced
this pull request
Sep 5, 2022
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
mirror behavior without overloadableEnums
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a symbol has both enum and non-enum (e.g. routine) overloads, and the first resolved overload (i.e. last declared) for that symbol is an enum, only consider the enum overloads for that symbol and ignore non-enum overloads. This mirrors behavior without
overloadableEnums.The need for this was discovered in #20076 in some packages and standard library/tests