fix stylecheck bug with nre

[ringabout]

Before nim r --stylecheck:error --eval:"import nre"

nre.nim(144, 22) Error: 'pcre' should be: 'Pcre' [type declared in C:\Users\blue\.choosenim\toolchains\nim-#devel\lib\wrappers\pcre.nim(257, 3)]   

type
  Regex* = ref object
    pattern*: string
    pcreObj: ptr pcre.Pcre  ## not nil
    pcreExtra: ptr pcre.ExtraData  ## nil

    captureNameToId: Table[string, int]

[ringabout]

proc builtinFieldAccess(c: PContext, n: PNode, flags: TExprFlags): PNode =
    markUsed(c, n[1].info, s)   # <----------  dotexpr is already checked here
    result = semSym(c, n, s, flags) # we shouldn't let semSym check dotexpr again 
    onUse(n[1].info, s)
    return

[ringabout]

find another same bug

serve.nim

const Serve* = 12

test.nim

import serve

echo serve.Serve

test.nim(9, 11) Error: 'serve' should be: 'Serve' [const declared in C:\Users\blue\Downloads\Nim\serve.nim(1, 7)]

[ringabout]

Ready for review

[arnetheduck]

Can we get a backport? been hitting this too.

[ringabout]

Can we get a backport? been hitting this too.

If you would like a commit to be backported (and it should), you can @narimiran in case that the message is ignored. Nowadays it seems that contributing to 1-6 branch directly is acceptable => #19697

[narimiran]

Nowadays it seems that contributing to 1-6 branch directly is acceptable

If somebody (accidentally) does it, it doesn't mean it is acceptable/preferred. I would much rather have PRs targeted at devel and marked as [backport].

[ringabout]

Though it happened multiple times:

#19583
#19269
#19047

Even the rule has already been written into the contributuing guide.