Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed strictFuncs support for std/pegs #18951

Merged
merged 3 commits into from
Oct 7, 2021
Merged

Fixed strictFuncs support for std/pegs #18951

merged 3 commits into from
Oct 7, 2021

Conversation

quantimnot
Copy link
Contributor

Enabled std/pegs in the strictFuncs import test.

Fixes #18057
Fixes #16892
See #18111

@quantimnot
Fixed strictFuncs support for std/pegs
bff35b6 
Enabled `std/pegs` in the `strictFuncs` import test.

Fixes nim-lang#18057
Fixes nim-lang#16892
See nim-lang#18111
@quantimnot
Rebased from devel
223a062
@quantimnot quantimnot force-pushed the pr_pegs_strictFuncs_support branch from 62ba2de to 223a062 Compare October 4, 2021 22:00
@quantimnot
Copy link
Contributor Author

I don't understand why CI is failing {.cast(noSideEffect).} usage in std/pegs but not in other modules that use it too.

@quantimnot
Copy link
Contributor Author

quantimnot commented Oct 5, 2021 •
edited
Loading

I see why it is failing now.
The bootstrap compiler in csource_v1 doesn't know of the cast pragma block. The build of koch fails because it imports std/pegs.

What is the solution?

@Araq
Copy link
Member

Araq commented Oct 5, 2021

We only need pegs for koch docs which we don't need for bootstrapping. So koch docs could delegate to a helper .exe that is allowed to have more dependencies than the koch tool itself. Not sure if that can be done without getting to ugly, but it's an idea.

@quantimnot
Conditionally compile std/pegs in koch
d401c0a 
This is for supporting `csources` bootstrap.
@Araq Araq merged commit 19774a7 into nim-lang:devel Oct 7, 2021
PMunch pushed a commit to PMunch/Nim that referenced this pull request Mar 28, 2022
@quantimnot @PMunch
Fixed strictFuncs support for std/pegs (nim-lang#18951)
52bd0c4 
* Fixed `strictFuncs` support for `std/pegs`

Enabled `std/pegs` in the `strictFuncs` import test.

Fixes nim-lang#18057
Fixes nim-lang#16892
See nim-lang#18111

* Rebased from `devel`

* Conditionally compile `std/pegs` in `koch`

This is for supporting `csources` bootstrap.

Co-authored-by: quantimnot <quantimnot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pegs.nim(344, 6) Error: 'nonterminal' can have side effects strictFuncs + views: cannot import pegs
2 participants
@quantimnot @Araq