Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delEnv now works at CT #18568

Merged
merged 1 commit into from
Jul 27, 2021
Merged

delEnv now works at CT #18568

merged 1 commit into from
Jul 27, 2021

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Jul 23, 2021

before PR:

  • putEnv works at CT
  • delEnv silently noop at CT (makes no sense to make this an exception given that putEnv works at CT)

after PR:

template main = ...
static: main()
main()

except for a few tests which would require #13714 to pass (and except for the ones that rely on threads:on)

I can add a changelog if requested but I consider this more of a bugfix.

@timotheecour timotheecour added the Ready For Review (please take another look): ready for next review round label Jul 25, 2021
@Araq
Copy link
Member

Araq commented Jul 27, 2021

Bugfix indeed because nimscript.nim contains:

proc delEnv*(key: string) {.tags: [WriteIOEffect].} =
  ## Deletes the environment variable named `key`.
  builtin

@Araq Araq merged commit 493721c into nim-lang:devel Jul 27, 2021
@timotheecour timotheecour deleted the pr_delEnv_vm branch July 27, 2021 15:57
PMunch pushed a commit to PMunch/Nim that referenced this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review (please take another look): ready for next review round
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants