Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

followup #18362: make UnusedImport work robustly #18366

Merged
merged 10 commits into from
Jun 27, 2021

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Jun 27, 2021

from a import b
import a except nil

@timotheecour timotheecour marked this pull request as ready for review June 27, 2021 17:48
@timotheecour timotheecour added the Ready For Review (please take another look): ready for next review round label Jun 27, 2021
@Araq Araq merged commit 0b7361e into nim-lang:devel Jun 27, 2021
@timotheecour timotheecour deleted the pr_followup_18362_unused_import branch June 27, 2021 18:52
@timotheecour timotheecour mentioned this pull request Jun 29, 2021
PMunch pushed a commit to PMunch/Nim that referenced this pull request Mar 28, 2022
…18366)

* warnDuplicateModuleImport => hintDuplicateModuleImport
* improve DuplicateModuleImport msg, add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review (please take another look): ready for next review round
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants