Fixes #5034 illformed AST from getImpl with proc returning value #17976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
changed the title
if it fixes it, write |
timotheecour
reviewed
May 9, 2021
timotheecour
reviewed
May 9, 2021
timotheecour
reviewed
May 9, 2021
timotheecour
reviewed
May 9, 2021
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
…lue (nim-lang#17976) * Fixes 5034 * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing #5034, whereby macros that attempt to re-define a proc run into a variety of issues relating to the ownership of the
resultsymbol. For example:addResult, on the 'second pass' would fail becausen[resultPos].sym.owner != getCurrOwner(c)which gives"incorrect result proc symbol"result = ...gets re-written toresult = result = ...becausesemReturninsemexprsdoes transformations twice due toc.p.resultSym != n[0][0].symin the case of returning nodes sourced fromgetImpl(Transformed)?As a fix, ownership mismatch is responded to by re-writing
resultnodes equal ton[resultPos].sym. As a less-preferred alternative to this PR, the error message for attempting to do this kind of redefinition could be improved to be discouraged.