Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable tmacro_highlight on i386, refs #17945 #17949

Merged

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented May 6, 2021

workaround refs #17945 which keeps causing issues (3 recent unrelated PRs)

CI failures unrelated

@timotheecour timotheecour changed the title disable tmacro_highlight on i386 disable tmacro_highlight on i386, refs #17945 May 6, 2021
@timotheecour
Copy link
Member Author

timotheecour commented May 6, 2021

@Araq I'm merging this as it affects several unrelated PRs; there are too many flaky tests and we should address those one by one. Feel free to revert later if you disagree.

I've intentionally kept the bug open so it can be investigated in due time but at least it won't affect other PRs

@timotheecour timotheecour merged commit 39e0a53 into nim-lang:devel May 6, 2021
@timotheecour timotheecour deleted the pr_disable_tmacro_highlight_i386 branch May 6, 2021 19:24
PMunch pushed a commit to PMunch/Nim that referenced this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant