Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declaredlocs followup: handle cannot instantiate errors #17745

Merged
merged 1 commit into from
Apr 18, 2021

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Apr 16, 2021

follows #15666 and #15673

IIRC that was the last remaining case

when true:
  type Foo[T: SomeInteger] = object
  var a: Foo[float]

before PR:

t12178.nim(8, 13) Error: cannot instantiate Foo
got: <typedesc[float]>
but expected: <T: SomeInteger>
    var a: Foo[float]

after PR:

t12178.nim(8, 13) Error: cannot instantiate Foo [type declared in t12178.nim(7, 8)]
got: <typedesc[float]>
but expected: <T: SomeInteger>
    var a: Foo[float]

@timotheecour timotheecour force-pushed the pr_declaredlocs_followup branch from 9243d2b to eba6a8f Compare April 18, 2021 16:33
@Araq Araq merged commit d6c8efa into nim-lang:devel Apr 18, 2021
@timotheecour timotheecour deleted the pr_declaredlocs_followup branch April 19, 2021 03:47
PMunch pushed a commit to PMunch/Nim that referenced this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants