-d:nimDebug: calls doAssert false instead of quit in compiler code #17739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
force-pushed
the
pr_nimDebug
branch
from
0d723ef to
c1c4e5b
Compare
timotheecour
force-pushed
the
pr_nimDebug
branch
from
c1c4e5b to
c4041c4
Compare
5 tasks
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #17706 (comment)
this allows getting a stacktrace (if nim was built with one, which could be via libbacktrace or --stacktrace) when compiler would've instead quit with
quitconf.isDefined("nimDebug")is preferable towhen defined(debug)as it doesn't involve re-compiling nim (and the cost of the check is insignificant)