Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added more modules to docs lib #17430

Merged
merged 8 commits into from
Mar 21, 2021
Merged

added more modules to docs lib #17430

merged 8 commits into from
Mar 21, 2021

Conversation

AFaurholt
Copy link
Contributor

Per Issue #16656 I tried to add the missing modules to the list. I wasn't sure what to do with io or assertions since they're listed under system

@AFaurholt AFaurholt changed the title added more modules added more modules to docs lib Mar 20, 2021
doc/lib.rst Outdated Show resolved Hide resolved
doc/lib.rst Outdated Show resolved Hide resolved
doc/lib.rst Outdated Show resolved Hide resolved
doc/lib.rst Outdated Show resolved Hide resolved
doc/lib.rst Outdated Show resolved Hide resolved
@konsumlamm
Copy link
Contributor

The modules should be ordered alphabetically and the modules in the std directory (jsonutils, enumerate, with) should have a std/ prefix (at least until #16999 is merged).

AFaurholt and others added 6 commits March 21, 2021 13:22
Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
@AFaurholt
Copy link
Contributor Author

Added the std/ and the other suggestions

@konsumlamm
Copy link
Contributor

See #17430 (comment).

@AFaurholt
Copy link
Contributor Author

See #17430 (comment).

Should be fixed now. Thanks for the catch

@Araq Araq merged commit 5bed7d2 into nim-lang:devel Mar 21, 2021
ringabout pushed a commit to ringabout/Nim that referenced this pull request Mar 22, 2021
* added more modules

* Update doc/lib.rst

Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>

* Update doc/lib.rst

Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>

* Update doc/lib.rst

Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>

* Update doc/lib.rst

Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>

* Update doc/lib.rst

Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>

* listed alphabetically + link to json module

* Added suggestion nim-lang#17430

Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
* added more modules

* Update doc/lib.rst

Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>

* Update doc/lib.rst

Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>

* Update doc/lib.rst

Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>

* Update doc/lib.rst

Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>

* Update doc/lib.rst

Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>

* listed alphabetically + link to json module

* Added suggestion nim-lang#17430

Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants