doc times: do not use now
(and also epochTime
) for benchmarking
#17405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common pitfall, eg
now
is used in nim-lang/website#274rationale:
epochTime
uses (on osx) gettimeofday which is non-monotonic, eg see [1]now
has same problems asepochTime
, and on top of that has overhead (which is really bad for benchmarking, depending on the time scales involved), and deals with timezones, and return typeDateTime
is a heavy object;links
future work
getMonoTime
CLOCK_MONOTONIC
, see https://linux.die.net/man/2/clock_gettime, on systems that have those options (and find nearest equivalent on osx):