Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std/lists: Various changes to lists (RFC #303) #16536

Merged
merged 13 commits into from
Feb 8, 2021
Merged

std/lists: Various changes to lists (RFC #303) #16536

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
da6e8ca
Various changes to `lists` (RFC #303)
salvipeter Dec 31, 2020
ab2ba9a
Removing a non-element is no-op; better tests
salvipeter Jan 1, 2021
9753b6b
Remove preserves cycles; add appendMove alias; tests.
salvipeter Jan 3, 2021
45a47f7
Return value for (singly linked) `lists.remove`
salvipeter Jan 13, 2021
a9085cb
More test for lists.remove
salvipeter Jan 14, 2021
c5ae194
Moved `lists.append` to the end of the file to see all `add` definitions
salvipeter Jan 19, 2021
e487328
Disable testing js for now
Clyybber Jan 20, 2021
e17a8ae
Use workaround for swap js bug
Clyybber Jan 21, 2021
1fdcd8a
Smaller diff
Clyybber Jan 21, 2021
e158639
Undo "silent" deprecation of append
Clyybber Jan 21, 2021
6e6d1de
Correct typo in changelog
Clyybber Jan 21, 2021
d9f371b
Remove `appendMoved`
salvipeter Jan 21, 2021
79995aa
Don't remove appendMoved
Clyybber Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,9 @@ with other backends. see #9125. Use `-d:nimLegacyJsRound` for previous behavior.
- Added `math.signbit`.

- Removed the optional `longestMatch` parameter of the `critbits._WithPrefix` iterators (it never worked reliably)
- In `lists`: renamed `append` to `add` and retained `append` (and added `appendMoved`) as an alias;
salvipeter marked this conversation as resolved.
Show resolved Hide resolved
added `prepend` and `prependMoved` analogously to `add` and `andMoved`;
Clyybber marked this conversation as resolved.
Show resolved Hide resolved
added `remove` for `SinglyLinkedList`s.

## Language changes

Expand Down
Loading