Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable nimgame2 #16445

Closed
wants to merge 1 commit into from
Closed

re-enable nimgame2 #16445

wants to merge 1 commit into from

Conversation

ringabout
Copy link
Member

No description provided.

@timotheecour timotheecour changed the title enable nimgame2 re-enable nimgame2 Dec 23, 2020
@timotheecour
Copy link
Member

this was disabled in #15935 ; what changed since then? or maybe it was already working after that PR?

@timotheecour timotheecour added the merge_when_passes_CI mergeable once green label Dec 23, 2020
@ringabout
Copy link
Member Author

ringabout commented Dec 23, 2020 •
edited
Loading

I'm just testing them and I will make a PR to fix nimgame2.

@ringabout ringabout marked this pull request as draft December 23, 2020 03:47
@ringabout ringabout removed the merge_when_passes_CI mergeable once green label Dec 23, 2020
@Araq
Copy link
Member

Araq commented Dec 27, 2020

nimgame2 worked for me with the deprecated "random" stuff removed.

@ringabout
Copy link
Member Author

ringabout commented Dec 27, 2020 •
edited
Loading

@Araq the issue is #16462
pragmagic/godot-nim#81

@ringabout ringabout closed this Jan 2, 2021
@ringabout ringabout deleted the nimgme2 branch April 6, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheecour timotheecour timotheecour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ringabout @timotheecour @Araq