Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix infinite recursion in typeRel #15241

Merged
merged 19 commits into from
Sep 18, 2020
Merged

fix infinite recursion in typeRel #15241

merged 19 commits into from
Sep 18, 2020

Conversation

jcosborn
Copy link
Contributor

No description provided.

@Clyybber
Copy link
Contributor

Clyybber commented Sep 15, 2020

@jcosborn FYI the snippet I mentionede here #15211 (comment) isn't supposed to compile, its supposed to say (13, 23) Error: expression 'prepareTileset(parsedTileset)' has no type (or is ambiguous)

You can specify that in the test file like so:

discard """
  errormsg: "expression 'prepareTileset(parsedTileset)' has no type (or is ambiguous)"
  line: 13
"""

@jcosborn
Copy link
Contributor Author

It works fine for me (no error) when I run the test on its own. I don't know why CI fails when it is included in megatest.

@Clyybber
Copy link
Contributor

Oh, yeah sorry. You are right it should compile just fine.

@jcosborn
Copy link
Contributor Author

type TilesetCT[n: static[int]] = int seems to make CI fail. It works fine in my own tests.
Changing it to type TilesetCT[n: static[int]] = distinct int seems to work with CI.

compiler/sigmatch.nim Outdated Show resolved Hide resolved
@Araq Araq merged commit e56d50d into nim-lang:devel Sep 18, 2020
Clyybber added a commit to Clyybber/Nim that referenced this pull request Sep 18, 2020
mildred pushed a commit to mildred/Nim that referenced this pull request Jan 11, 2021
* fix generic constraints

Co-authored-by: James Osborn <osborn@Jamess-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants