Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strutils: Make the invalidFormatString error a bit more informative #14486

Closed

Conversation

kaushalmodi
Copy link
Contributor

@kaushalmodi kaushalmodi commented May 28, 2020

The error in #14485 said just:

Error: unhandled exception: invalid format string [ValueError]

This PR will add a bit more context to that particular exception.

Ref: #14485

@timotheecour
Copy link
Member

see also #14282 (which i forgot to convert from draft)

@kaushalmodi
Copy link
Contributor Author

#14282 is certainly more informative than my quick stab in this PR. I don't see why that draft PR cannot be committed.

@timotheecour
Copy link
Member

i guess i was just trying to settle on the most useful debug output; since this is at least the 2nd concrete use case i'll convert it soon

@kaushalmodi
Copy link
Contributor Author

Can you also commit #14282? I can then close this.

@timotheecour
Copy link
Member

Can you also commit #14282? I can then close this.

I will... soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants