Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated things in macros except for callsite #13710

Closed
wants to merge 1 commit into from
Closed

remove deprecated things in macros except for callsite #13710

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 20, 2020

From what I can tell these have all been deprecated for 2 years or more.
I'll leave this here for when it is time to clean them up.

callsite's future is uncertain (see: #11864) so didn't touch it.

@krux02
Copy link
Contributor

krux02 commented Mar 21, 2020

Of course these deprecated symbols are used a lot in packages, because back then when I marked them as deprecated I also just introduced the substitution. If you want to make this PR test green, I am sorry I think you have to make a lot of PR for all the important packages as well. If you make a PR with just the changes where you don't use the deprecated symbols anymore (but without the removal of any feature), it will be valuable and it will be approved quickly (at least from me).

Regarding callsite: callsite is only used to get the line information of the callsite. A specific magic proc for that could take that over.

@ghost ghost closed this May 19, 2020
@timotheecour
Copy link
Member

timotheecour commented May 21, 2020

@dumjyl just curious whether you closed because you don't have time to work on this (which is fine) or for some other reason?
as @krux02 said, a less ambitious PR would work great in the meantime and represent less work for you

@timotheecour timotheecour added the stale Staled PR/issues; remove the label after fixing them label May 21, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Staled PR/issues; remove the label after fixing them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants