-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] fix #6999 (allow [nimDocOnly] in commit msg); fix #13477 (flaky nodejs install); log PR url (+other info) in runCI logs #13556
Conversation
4ab4833
to
da8bd3a
Compare
da8bd3a
to
6b8b284
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log a few other relevant variables that help when looking at runCI logs (the main log that contains almost all of nim CI), so they're self contained when shared
- the PR url so it's easy to find originating PR when looking at those
- the number of CPU's (helps when interpreting differences in timing results; some have 2, some have 4 in azure IIRC)
- build ID + 1 or 2 more relevant info
The idea isn't bad, but please actually format the data so that human can parse it rather than dump it all out.
7c45c16
to
50d8221
Compare
done, shows:
|
6813cc7
to
16c26ae
Compare
…w PR url + other info
16c26ae
to
0ae1ae1
Compare
This pull request has been automatically marked as stale because it has not had recent activity. If you think it is still a valid PR, please rebase it on the latest devel; otherwise it will be closed. Thank you for your contributions. |
EDIT 2020-05-13: this PR is useful but needs to be updated to reflect recent changes in how CI works; in particular can be modified to handle
[ci skip]
which isn't working in azure pipelines)[nimDocOnly]
will only build nim and run nim doc-related stuff[nimDocOnly]
commits: ~ 4mn per machine instead of ~30mnInstall node.js 8.x
flaky step #13477Install node.js 8.x
flaky step[CI]
Install node.js 8.x
flaky step #13477 keeps happening regularly (and even breaks with different error messages depending on the time) ; and it's simpler anyway to install directly from system package installers, egbrew
on OSX ; furthermore, moving more logic into Nim code (installNode
) is better (less dependency on CI specific logic, which makes it easier to switch as needed or work with multiple CI's)eg for this PR, CI logs for the runCI step (eg like https://dev.azure.com/nim-lang/Nim/_build/results?buildId=2984&view=logs&j=a0440cd6-2060-5545-8b53-639e777de0c6)
will show this (and urls' are clickable):
[EDIT]: that issue just happened again in https://dev.azure.com/nim-lang/Nim/_build/results?buildId=3007&view=logs&jobId=30931762-47c4-53b3-6a83-316eb5a6b9d7&j=30931762-47c4-53b3-6a83-316eb5a6b9d7&t=a385ca32-7847-5843-f526-f36e9a71a329
https://dev.azure.com/nim-lang/Nim/_build/results?buildId=3523&view=logs&jobId=1effb61f-3820-5ca5-606b-caa183b197b5&j=1effb61f-3820-5ca5-606b-caa183b197b5&t=17e5f679-7cb9-5688-0d47-09c257156869