Fix #9405 - cfg and nims run in sync

[genotrance]

No description provided.

[genotrance]

Test is failing in devel itself.

testament run tests/osproc/texitcode.nim

[genotrance]

#13449

[Araq]

I fixed it too here, #13461

Not sure which version I like better though. Yours seem to avoid some code duplication.

[genotrance]

I just moved most of the code into loadConfigs() since I felt it gets used in many more places and simplified loadConfigsAndRunMainCommand(). But until CI passes, I have no idea if I did this right.

[timotheecour]

But until CI passes, I have no idea if I did this right.

for now just close/reopen (#13449 is flaky, not failing always) EDIT: I've sent a PR to fix it #13487

Not sure which version I like better though. Yours seem to avoid some code duplication.

• indeed; I prefer this version, eg now optSkipUserConfigFile appears only once , whereas in fixes #9405 #13461 it appears twice (ditto with other such flags)

• however, as explained here Fix #9405 - cfg and nims run in sync; correctly honor cmdline --hint:conf:on/off ; correctly show Conf hints in order #13488 this PR has correctness issues that are addressed in Fix #9405 - cfg and nims run in sync; correctly honor cmdline --hint:conf:on/off ; correctly show Conf hints in order #13488, which builds upon this PR

[disruptek]

Is there a way for nimph to not run the NimScript while parsing with loadConfigs? This seems like a breaking change for me...

[timotheecour]

Is there a way for nimph to not run the NimScript while parsing with loadConfigs? This seems like a breaking change for me...

nim --fullhelp:
--skipCfg:on|off do not read the nim installation's configuration file
--skipUserCfg:on|off do not read the user's configuration file
--skipParentCfg:on|off do not read the parent dirs' configuration files
--skipProjCfg:on|off do not read the project's configuration file

[disruptek]

Sure, but nimph is running loadConfigs directly from the compiler/... After talking to @genotrance it sounds like this is obsolescence by design, so we'll make it work no matter how slow/broken it is. 👍

[genotrance]

Superseded by #13488