Add idxmin() and idxmax() #12976
Closed
Add idxmin() and idxmax() #12976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that MultipartData objects are easily accessible.
cooldome
reviewed
Dec 27, 2019
| @@ -390,6 +390,7 @@ proc `[]=`*(p: var MultipartData, name: string, | |||
|
|
|||
| proc format(p: MultipartData): tuple[contentType, body: string] = | |||
| if p == nil or p.content.len == 0: | |||
|
|
|||
There was a problem hiding this comment.
unrelated change please remove from this PR
|
The aim is to keep system.nim lean. |
|
This should be moved to |
|
Yep, return type is incorrect. Plus tests are required. |
|
this doesn't work for arrays with non-zero starting index. |
|
I think this is too trivial and not useful enough to jump into stdlib. It would need a |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are two procedures that return the index of the corresponding minimum and maximum value