Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the mention of using discard for block comments #12837

Merged
merged 2 commits into from
Dec 8, 2019
Merged

Removing the mention of using discard for block comments #12837

merged 2 commits into from
Dec 8, 2019

Conversation

elliotwaite
Copy link
Contributor

The removed line mentions that the comments section describes how to use the discard statement to create block comments. However, the comments section does not mention using a discard statement. It instead only mentions using the #[ and ]# syntax. If that is the new preferred method of creating block comments, perhaps this line should be removed, which is what this change does.

Alternatively, if the documentation wants to present both solutions, I could instead update this change to replace the link to the comments section with an inline explanation of how you can also use the discard statement with long string literals to create block comments. If this would be preferred, let me know and I can update this pull request.

@elliotwaite elliotwaite changed the title Remove mention of using discard for block comments in tutorial Remove mention of using discard for block comments in the tutorial Dec 8, 2019
@elliotwaite elliotwaite changed the title Remove mention of using discard for block comments in the tutorial Removing the mention of using discard for block comments Dec 8, 2019
@Araq
Copy link
Member

Araq commented Dec 8, 2019

It was decided back then not to mention the usage of discard for comments in the tutorials.

@Araq Araq merged commit 5da27a8 into nim-lang:devel Dec 8, 2019
narimiran pushed a commit to narimiran/Nim that referenced this pull request Dec 10, 2019
…12837) [backport]

* Remove mention of using `discard` for block comments

* Add a 32x32 alternate favicon

(cherry picked from commit 5da27a8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants