Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arc devel #12781

Merged
merged 25 commits into from
Dec 5, 2019
Merged

arc devel #12781

merged 25 commits into from
Dec 5, 2019

Conversation

Araq
Copy link
Member

@Araq Araq commented Nov 30, 2019

more ARC related bugfixes and refactorings

@Araq
Copy link
Member Author

Araq commented Dec 1, 2019

@cooldome please test this branch with your codebase.

@cooldome
Copy link
Member

cooldome commented Dec 1, 2019

Sure, can do it on Monday

@cooldome
Copy link
Member

cooldome commented Dec 2, 2019

I wanted to try this one today but I have found that thanks to the #12766 fix, the code now compiles
with latest Nim devel but I get crashes at the runtime. Need to chase them down.
One was very weird, when I compile the whole project a simple proc in one module:

proc add(c: Container, x: sink MyValue)

didn't get the destructor injection for x argument. But when I compile just this module it gets destructor injection. No generics, no inline.

Will keep on debugging and compare generated code.

@Araq
Copy link
Member Author

Araq commented Dec 4, 2019

@cooldome If the current devel cannot compile your projects we might as well go ahead and merge this PR, right?

@cooldome
Copy link
Member

cooldome commented Dec 5, 2019

Yes, looks like is going to take some time to trace it down. Please submit and we can fix it later.

@Araq Araq added the merge_when_passes_CI mergeable once green label Dec 5, 2019
@narimiran
Copy link
Member

narimiran commented Dec 5, 2019

Note to the person who will merge this: beware that some of the commits have [backport] tag. Merge carefully :)

EDIT: I've just been told that those two commits are already in devel. I'm squashing+merging this then.

@narimiran narimiran merged commit 3fbb3bf into devel Dec 5, 2019
@Araq Araq deleted the araq-arc-devel branch December 5, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants