-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmetic compiler cleanup #12718
Cosmetic compiler cleanup #12718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the "Unify range operators" commit — I would like to see it unified in the opposite direction, with spaces before and after ..
and ..<
, as that is the recommended style.
@narimiran I think |
79fce16
to
2aef22e
Compare
8ea1084
to
dfc434f
Compare
Summary
SomePNodeOrPType.sons[...]
->.SomePNodeOrPType[...]
SomeIndexable[SomeIndexable.len - x]
->SomeIndexable[^x]
Removed
L
/length
variables where they went unused due to the above changeRemoved the
PTransfNode
type fromtransf.nim
Removed
addSon
and replaced it withadd
since it is the sameChanged all
add
calls to use method call syntaxChanged all
len
/safeLen
calls to use method call syntaxChanged ranges of the form
x..something.len-(y+1)
tox..<something.len-y