#12103 - CI for OpenBSD #12105
Merged
#12103 - CI for OpenBSD #12105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there are quite a few failures. A bunch of them are related to (the above is repeated a whole lot... not sure why?) The above is valid - There are a couple of out of memory ones too, we probably just want to disable those tests for OpenBSD. |
Araq
reviewed
Sep 2, 2019
|
Here's a run of the FreeBSD CI, which unfortunately fails due to #12113. I've marked this PR as ready for review rather than WIP. |
|
Current OpenBSD test failures are pasted here, as of current PRs: https://paste.sr.ht/%7Eeuantorano/f69c3bd1374e96ce0b0b2ec848b43f4b1ed0e248 |
|
Ready to be merged? |
|
@Araq the FreeBSD CI doesn’t work at all (see #12113) and there are still several OpenBSD failures. So really, it’s up to you. I can move the FreeBSD one to a separate PR and we can get started with OpenBSD if that would be easy? Well also need either you or @dom96 (or somebody else with repository access) to set up the sr.ht integration. |
Sure, just tell me what to do. Tests can be disabled for specific platforms via |
|
Yep, I’ll add to this PR to disable tests that I don’t already have open PRs to fix and will remove the FreeBSD build. I should get that done tonight hopefully.
Regarding the sr.ht side, you will need to create an account at: https://meta.sr.ht/register
Then head to https://dispatch.sr.ht/configure and add tasks for GitHub commits and GitHub pull requests.
…On Tue, 10 Sep 2019, at 18:21, Andreas Rumpf wrote:
>
> I can move the FreeBSD one to a separate PR and we can get started with OpenBSD if that would be easy?
Sure, just tell me what to do. Tests can be disabled for specific platforms via `disabled: "openbsd"` (requires a testament patch but should be trivial).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#12105?email_source=notifications&email_token=AAFW24J6RI6QMTRFA26GOQTQI7JTNA5CNFSM4ISX2LI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6L3UTY#issuecomment-530037327>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFW24PAI2W4Y4464FPVA4DQI7JTNANCNFSM4ISX2LIQ>.
|
|
@Araq Ok, should be good to merge now. Once this is merged, I'll open more issues for other OpenBSD specific issues and try to sort them out. For reference, this is the most recent CI run using this manifest and the current output from a run against the repository's I'll open a new PR for FreeBSD once this is merged as the moment |
euantorano
changed the title
euantorano
force-pushed
the
fix/12103-builds.sr.ht-ci
branch
from
e3645a9 to
32e745b
Compare
|
Seems my earlier PR for Not sure how to proceed. |
|
@alaviss you are our CI expert :) Can you take a look and give your opinion/review? |
alaviss
reviewed
Oct 28, 2019
euantorano
force-pushed
the
fix/12103-builds.sr.ht-ci
branch
from
0ebab6d to
45f98c0
Compare
Current Failures
The other errors need further investigation. |
euantorano
force-pushed
the
fix/12103-builds.sr.ht-ci
branch
from
52ebe42 to
e25889e
Compare
Current FailuresThe one I could really do with some help with is the repeated |
euantorano
force-pushed
the
fix/12103-builds.sr.ht-ci
branch
from
6afe660 to
68e8790
Compare
|
PR rebased, CI failed before it had even finished the setup stage: Is there any way to debug these types of issues more easily - such as to dump the paths that the file was looked for within? Its obviously getting the path wrong, and this type of error seems to happen a lot on OpenBSD for some reason. |
euantorano
force-pushed
the
fix/12103-builds.sr.ht-ci
branch
from
68e8790 to
8a3b09a
Compare
euantorano
force-pushed
the
fix/12103-builds.sr.ht-ci
branch
3 times, most recently
from
697b2fe to
fd07766
Compare
|
Tests passing at last! There are quite a few tests disabled, but I figure they can be fixed and enabled at a later date - at least this would catch any future regressions. I’ll open an issue listing the disabled tests with reasons so they can be worked through in the future. |
…can be enabled at a later date after fixing them.
euantorano
force-pushed
the
fix/12103-builds.sr.ht-ci
branch
from
d443334 to
1fa9e57
Compare
|
Rebased, awaiting test completion. Created an issue for disabled tests: #14035 |
|
Build is passing for OpenBSD, the failures are for other CI platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress fix for #12103 - it adds CI support for OpenBSD and I'll be adding FreeBSD support too if everyone's happy with the OpenBSD one.
I've got a build running right now - build #86238. In past runs there have been a few failures which look like they may be genuine errors - I'll probably end up creating a few issues for these once confirmed.