travis: cleanup & add 32-bit Linux testing #11337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaviss
force-pushed
the
travis-32bit
branch
5 times, most recently
from
941887d to
b1f997f
Compare
alaviss
force-pushed
the
travis-32bit
branch
3 times, most recently
from
596ce0e to
d72f876
Compare
Having `set -e` broke `after_failure`. This commit removes them where appropriate. According to https://docs.travis-ci.com/user/job-lifecycle#breaking-the-build, only the script phase ignore errors, but it's totally harmless in this case.
From experiment in https://travis-ci.org/alaviss/Nim/jobs/537612750, this is no longer necessary.
narimiran
reviewed
May 29, 2019
| @@ -9,6 +9,7 @@ proc `@`[IDX, T](a: array[IDX, T]): seq[T] | |||
|
|
|||
| expression: @[int] | |||
| ''' | |||
| disabled: "32bit" | |||
There was a problem hiding this comment.
Due to this one new line, change lines 3-5 from 15 to 16:
line: 16
nimout: '''
twrong_at_operator.nim(16, 30) Error: type mismatch: got <array[0..0, type int]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently 32-bit Linux doesn't bootstrap. I don't know if it's my fault ordevelgot a regression.EDIT: Tested with a known good config, this is a
develregression caused by 3a06022Bonus goodies:
after_failureis now triggered correctly and will print out a nice summary of failed tests./cc @Araq