Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #10488 GC memory leak regression #10498

Merged
merged 2 commits into from
Jan 30, 2019
Merged

fix #10488 GC memory leak regression #10498

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daa14ad
fix #10488 GC memory leak regression
timotheecour Jan 30, 2019
21bb2e9
re-enable gch.stack.bottom.repr but only inside when defined(logGC)
timotheecour Jan 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/system/gc.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,7 +864,10 @@ when not defined(useNimRtl):
for stack in items(gch.stack):
result.add "[GC] stack " & stack.bottom.repr & "[GC] max stack size " & cast[pointer](stack.maxStackSize).repr & "\n"
else:
result.add "[GC] stack bottom: " & gch.stack.bottom.repr
# this caused memory leaks, see #10488 ; find a way without `repr`
# maybe using a local copy of strutils.toHex or snprintf
when defined(logGC):
result.add "[GC] stack bottom: " & gch.stack.bottom.repr
result.add "[GC] max stack size: " & $gch.stat.maxStackSize & "\n"

{.pop.} # profiler: off, stackTrace: off