Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #10073 #10218

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Fix #10073 #10218

merged 1 commit into from
Jan 7, 2019

Conversation

zah
Copy link
Member

@zah zah commented Jan 6, 2019

No description provided.

This was referenced Jan 6, 2019
Closed
Closed
@timotheecour timotheecour mentioned this pull request Jan 7, 2019
Closed
2 tasks
@timotheecour
Copy link
Member

also fixes part of #10185

when true:
  type Foo[T: static int] = object
    arr: array[T, float]
  type B = Foo[3]

  type Foo2[T: static int] = array[T, float]
  type B2 = Foo2[3]

(not the other part with HSlice[int,int] though)
unfortunately I'm for some reason blocked from commenting on #10185

@Araq Araq merged commit 87f8ec5 into devel Jan 7, 2019
timotheecour added a commit to timotheecour/Nim that referenced this pull request Jan 9, 2019
@timotheecour
remove workaround in tests/vm/tissues.nim failing test now that nim-l…
31f32f4 
…ang#10218 was makes it work
@timotheecour timotheecour mentioned this pull request Jan 9, 2019
Merged
timotheecour added a commit that referenced this pull request Jan 9, 2019
@timotheecour
add isNamedTuple; make $(1, 2) be (1, 2) instead of (Field0: 1, Fie…
6ce3949 
…ld1: 2) which leaked implementation detail (#10070)

* add `isNamedTuple`; make $(1, 2) be (1, 2) instead of leaking implementation detail (Field0: 1, Field1: 2)
  fixes this: #8670 (comment) /cc @alehander42 @Vindaar @mratsim

* Note: isNamedTuple is useful in other places, eg #10010 (comment)

* move isNamedTuple to helpers.nim to avoid exposing new symbol to system.nim

* remove workaround in tests/vm/tissues.nim failing test now that #10218 was makes it work
@narimiran narimiran deleted the fix-10073 branch January 9, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zah @timotheecour @Araq