Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import sharedtables, tables causes CT errors when API's are used #13504

Closed
timotheecour opened this issue Feb 26, 2020 · 0 comments · Fixed by #13498
Closed

import sharedtables, tables causes CT errors when API's are used #13504

timotheecour opened this issue Feb 26, 2020 · 0 comments · Fixed by #13498

Comments

@timotheecour
Copy link
Member

import sharedtables, tables causes CT errors when API's are used

Example

import sharedtables
import tables

block:
  var table: SharedTable[int, int]
  init(table)
  table[1] = 10 # tableimpl.nim(120, 9) Error: type mismatch: got <KeyValuePairSeq[system.int, system.int], int literal(64)>
  # doAssert table.mgetOrPut(3, 7) == 7 # ditto
  deinitSharedTable(table)

Current Output

Error: type mismatch: got <KeyValuePairSeq[system.int, system.int], int literal(64)>

Expected Output

works

Additional Information

  • broken in 1.0.6
  • broken in 3dad130 devel 1.1.1
timotheecour added a commit to timotheecour/Nim that referenced this issue Feb 26, 2020
Araq pushed a commit that referenced this issue Feb 26, 2020
… of tests (#13498) [backport]

* fix #13496 handle tombstones
* add test
* more tests
* fix #13504; add SharedTable tests
* fix ##13505 intsets.missingOrExcl silently gave wrong results sometimes
* add test for tintsets
narimiran pushed a commit that referenced this issue Apr 14, 2020
… of tests (#13498) [backport]

* fix #13496 handle tombstones
* add test
* more tests
* fix #13504; add SharedTable tests
* fix ##13505 intsets.missingOrExcl silently gave wrong results sometimes
* add test for tintsets

(cherry picked from commit 42dad3a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant