[easy] --hint:link:on now shows link cmd instead of nothing (#13056)

* --hint:link:on now shows link cmd instead of nothing * update doc for --listCmd
nim-lang · Jan 7, 2020 · e5ae7ce · e5ae7ce
1 parent 569d4d1
commit e5ae7ce
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/.gitignore b/.gitignore
@@ -86,3 +86,6 @@ megatest.nim
 /lib/pure/*.js
 
 !/.builds/
+
+# ignore debug dirs generated by dsymutil on OSX
+*.dSYM
diff --git a/compiler/extccomp.nim b/compiler/extccomp.nim
@@ -835,8 +835,7 @@ template tryExceptOSErrorMessage(conf: ConfigRef; errorPrefix: string = "", body
 
 proc execLinkCmd(conf: ConfigRef; linkCmd: string) =
   tryExceptOSErrorMessage(conf, "invocation of external linker program failed."):
-    execExternalProgram(conf, linkCmd,
-      if optListCmd in conf.globalOptions or conf.verbosity > 1: hintExecuting else: hintLinking)
+    execExternalProgram(conf, linkCmd, hintLinking)
 
 proc maybeRunDsymutil(conf: ConfigRef; exe: AbsoluteFile) =
   when defined(osx):

diff --git a/compiler/lineinfos.nim b/compiler/lineinfos.nim
@@ -115,7 +115,7 @@ const
     hintName: "$1",
     hintPattern: "$1",
     hintExecuting: "$1",
-    hintLinking: "",
+    hintLinking: "$1",
     hintDependency: "$1",
     hintSource: "$1",
     hintPerformance: "$1",

diff --git a/doc/advopt.txt b/doc/advopt.txt
@@ -117,7 +117,8 @@ Advanced options:
                             dynlib: "liblua.so.3"
   --dynlibOverrideAll
                             disables the effects of the dynlib pragma
-  --listCmd                 list the commands used to execute external programs
+  --listCmd                 list the compilation commands; can be combined with:
+                            --hint:exec:on and --hint:link:on
   --asm                     produce assembler code
   --parallelBuild:0|1|...   perform a parallel build
                             value = number of processors (0 for auto-detect)