modulegraphs.dependsOn does not work on transitive modules

- make sure transitive deps are marked as dirty
nim-lang · Jun 14, 2022 · 5fa7e3b · 5fa7e3b
1 parent 9c1a369
commit 5fa7e3b
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/compiler/modulegraphs.nim b/compiler/modulegraphs.nim
@@ -591,7 +591,12 @@ proc markClientsDirty*(g: ModuleGraph; fileIdx: FileIndex) =
   # every module that *depends* on this file is also dirty:
   for i in 0i32..<g.ifaces.len.int32:
     if g.deps.contains(i.dependsOn(fileIdx.int)):
-      g.markDirty(FileIndex(i))
+      let
+        fi = FileIndex(i)
+        module = g.getModule(fi)
+      if module != nil and not g.isDirty(module):
+        g.markDirty(fi)
+        g.markClientsDirty(fi)
 
 proc needsCompilation*(g: ModuleGraph): bool =
   # every module that *depends* on this file is also dirty: