Skip to content

Commit

Permalink
refs #18011 disable some newly failing tests on cpp windows; refs #17946
Browse files Browse the repository at this point in the history
 increase timeout for tchannels (#18012)
  • Loading branch information
timotheecour authored May 14, 2021
1 parent 97970d9 commit 2ce592a
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 8 deletions.
8 changes: 4 additions & 4 deletions lib/system.nim
Original file line number Diff line number Diff line change
Expand Up @@ -1317,10 +1317,10 @@ proc del*[T](x: var seq[T], i: Natural) {.noSideEffect.} =
##
## See also:
## * `delete <#delete,seq[T],Natural>`_ for preserving the order
##
## .. code-block:: Nim
## var i = @[1, 2, 3, 4, 5]
## i.del(2) # => @[1, 2, 5, 4]
runnableExamples:
var a = @[10, 11, 12, 13, 14]
a.del(2)
assert a == @[10, 11, 14, 13]
let xl = x.len - 1
movingCopy(x[i], x[xl])
setLen(x, xl)
Expand Down
4 changes: 3 additions & 1 deletion tests/cpp/temitlist.nim
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
discard """
targets: "cpp"
output: '''6.0
output: '''
6.0
0'''
disabled: "windows" # pending bug #18011
"""

# bug #4730
Expand Down
4 changes: 3 additions & 1 deletion tests/cpp/tempty_generic_obj.nim
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
discard """
targets: "cpp"
output: '''int
output: '''
int
float'''
disabled: "windows" # pending bug #18011
"""

import typetraits
Expand Down
4 changes: 3 additions & 1 deletion tests/exception/tcpp_imported_exc.nim
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
discard """
targets: "cpp"
output: '''caught as std::exception
output: '''
caught as std::exception
expected
finally1
finally2
Expand All @@ -12,6 +13,7 @@ finally 2
expected
cpp exception caught
'''
disabled: "windows" # pending bug #18011
"""

type
Expand Down
2 changes: 1 addition & 1 deletion tests/stdlib/tchannels.nim
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
discard """
timeout: 20.0 # but typically < 1s (in isolation but other tests running in parallel can affect this since based on epochTime)
timeout: 60.0 # but typically < 1s (in isolation but other tests running in parallel can affect this since based on epochTime)
disabled: "freebsd"
matrix: "--gc:arc --threads:on; --gc:arc --threads:on -d:danger"
"""
Expand Down

0 comments on commit 2ce592a

Please sign in to comment.