Safely close autocomplete streams on the server to avoid logspam

Fixes deephaven#3162
niloc132 · Dec 8, 2022 · 227652d · 227652d
1 parent 4a8beb5
commit 227652d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/server/src/main/java/io/deephaven/server/console/ConsoleServiceGrpcImpl.java b/server/src/main/java/io/deephaven/server/console/ConsoleServiceGrpcImpl.java
@@ -302,9 +302,7 @@ public void onError(Throwable t) {
         @Override
         public void onCompleted() {
             // just hang up too, browser will reconnect if interested
-            synchronized (responseObserver) {
-                responseObserver.onCompleted();
-            }
+            safelyExecuteLocked(responseObserver, responseObserver::onCompleted);
         }
     }
 

diff --git a/server/src/main/java/io/deephaven/server/console/completer/JavaAutoCompleteObserver.java b/server/src/main/java/io/deephaven/server/console/completer/JavaAutoCompleteObserver.java
@@ -167,8 +167,6 @@ public void onError(Throwable t) {
     @Override
     public void onCompleted() {
         // just hang up too, browser will reconnect if interested
-        synchronized (responseObserver) {
-            responseObserver.onCompleted();
-        }
+        safelyExecuteLocked(responseObserver, responseObserver::onCompleted);
     }
 }
diff --git a/server/src/main/java/io/deephaven/server/console/completer/PythonAutoCompleteObserver.java b/server/src/main/java/io/deephaven/server/console/completer/PythonAutoCompleteObserver.java
@@ -232,8 +232,6 @@ public void onError(Throwable t) {
     @Override
     public void onCompleted() {
         // just hang up too, browser will reconnect if interested
-        synchronized (responseObserver) {
-            responseObserver.onCompleted();
-        }
+        safelyExecuteLocked(responseObserver, responseObserver::onCompleted);
     }
 }