Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamepadui #386

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Gamepadui #386

wants to merge 2 commits into from

Conversation

celisej567
Copy link

Basic implementation of GamepadUI from EZ2.
Tested on HL2. Cant test on Episodic.
Doesnt work on Portal for some reason.

Other games: Idk

@hangocdinhnew
Copy link

hangocdinhnew commented Nov 12, 2024

Great work, by the way! The only problem with this pull request is that you didn't add SDL2 as an library in the gamepadui wscript, which results in a build error.

@hangocdinhnew
Copy link

hangocdinhnew commented Nov 12, 2024

And also the fact that you added bitmap after mathlib, causes an linker error in GCC, and will make Gamepad UI not work in regular Clang (in the wscript)

@celisej567
Copy link
Author

Ive tested it only on windows, so makes sense.

@celisej567
Copy link
Author

celisej567 commented Nov 12, 2024

As nillerusr said to me, he will implement my pull request only after some digging in there. He found some things to fix there. So i think at the time when this will be implemented, it will work normally.

@hangocdinhnew
Copy link

Ive tested it only on windows, so makes sense.

You said "Cant test on Episodic" right? I've tested it, and it works fine, the only thing right now is Portal, which is missing a logo, and also the loading circle around the portal thing in the loading screen is orange, so there's that, but other than that, Portal is sort of functional.

@hangocdinhnew
Copy link

hangocdinhnew commented Nov 12, 2024

Here's the general platform compatibility:

Windows: Works (Out of the box).
MacOS: Works* (Only needed a patch).
Linux: Works* (Needed two patch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants