Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for config env variables #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for config env variables #8

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 28, 2018

Addressing issue #3

nikotrone
nikotrone requested changes Oct 28, 2018
View reviewed changes
Copy link
Owner

@nikotrone nikotrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please implement the two things in separate functions? Otherwise the function name is misleading.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nikotrone