Skip to content

Commit

Permalink
v1.22.10: remove obsolete fiori lunchmenu stuff
Browse files Browse the repository at this point in the history
  • Loading branch information
nikolockenvitz committed Jun 26, 2024
1 parent 7805f16 commit 7e4e2af
Show file tree
Hide file tree
Showing 12 changed files with 14 additions and 147 deletions.
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,15 @@
<a href="https://nikolockenvitz.github.io/sap-addon/">
<img src="https://nikolockenvitz.github.io/sap-addon/icons/icon48.png" height="20px" /></a>
<!-- SHIELD IO BADGES INSTALL START -->
<a href="https://nikolockenvitz.github.io/sap-addon/xpi/sap_addon-1.22.8.xpi">
<img src="https://img.shields.io/badge/firefox-v1.22.8-FF7139?logo=firefox-browser" alt="Install for Firefox" /></a>
<a href="https://nikolockenvitz.github.io/sap-addon/xpi/sap_addon-1.22.10.xpi">
<img src="https://img.shields.io/badge/firefox-v1.22.10-FF7139?logo=firefox-browser" alt="Install for Firefox" /></a>
<!-- SHIELD IO BADGES INSTALL END -->
<a href="https://chrome.google.com/webstore/detail/sap-addon/ccjpkhcdklddbfpcboffbeihonalpjkc">
<img src="https://img.shields.io/badge/chrome-v1.22.8-4285F4?logo=google-chrome" alt="Install for Chrome" /></a>
<img src="https://img.shields.io/badge/chrome-v1.22.10-4285F4?logo=google-chrome" alt="Install for Chrome" /></a>
<a href="https://chrome.google.com/webstore/detail/sap-addon/ccjpkhcdklddbfpcboffbeihonalpjkc">
<img src="https://img.shields.io/badge/brave-v1.22.8-FB542B?logo=brave" alt="Install for Brave" /></a>
<img src="https://img.shields.io/badge/brave-v1.22.10-FB542B?logo=brave" alt="Install for Brave" /></a>
<a href="https://chrome.google.com/webstore/detail/sap-addon/ccjpkhcdklddbfpcboffbeihonalpjkc">
<img src="https://img.shields.io/badge/edge-v1.22.8-0078D7?logo=microsoft-edge" alt="Install for Edge" /></a>
<img src="https://img.shields.io/badge/edge-v1.22.10-0078D7?logo=microsoft-edge" alt="Install for Edge" /></a>
<a href="https://www.mozilla.org/en-US/firefox/new/">
<img src="https://img.shields.io/badge/safari-not_available-000000?logo=safari" alt="Not available for Safari" /></a>
<br />
Expand Down
5 changes: 0 additions & 5 deletions background_scripts/chrome-background.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
try {
importScripts(
"./fetch-github-name.js",
"./chrome-fiori-lunchmenu.js",
"../shared/dynamic-content-scripts-config.js",
"./chrome-permission-manager.js"
);
Expand All @@ -15,10 +14,6 @@ chrome.runtime.onMessage.addListener(function (request, sender, sendResponse) {
resultPromise.then((username) => sendResponse(username));
return true;
}
if (request.rerunMainFunctionOfBackgroundPage) {
const { config, options } = request;
fioriLunchmenuUpdateDeclarativeNetRequest({ config, options });
}
});

async function onTabActivated() {
Expand Down
42 changes: 0 additions & 42 deletions background_scripts/chrome-fiori-lunchmenu.js

This file was deleted.

53 changes: 0 additions & 53 deletions background_scripts/fx-fiori-lunchmenu.js

This file was deleted.

3 changes: 0 additions & 3 deletions background_scripts/fx-message-listener.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,4 @@ browser.runtime.onMessage.addListener(function (request, sender, sendResponse) {
return true;
}
}
if (request.rerunMainFunctionOfBackgroundPage) {
main();
}
});
9 changes: 1 addition & 8 deletions docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
- [Auto Login](#auto-login)
- [GitHub - People's Full Names Instead of User IDs](#github---peoples-full-names-instead-of-user-ids)
- [GitHub - Hiding Yellow Announcement Banners](#github---hiding-yellow-announcement-banners)
- [Fiori Launchpad - Override Lunchmenu Language](#fiori-launchpad---override-lunchmenu-language)
- [SAP Jira - Count Tips](#sap-jira---count-tips)
- [Settings Popup](#settings-popup)
- [Configuration](#configuration)
Expand Down Expand Up @@ -36,12 +35,6 @@
* new messages will always appear
* if you dismissed a message by accident, you can show all banners again by clicking on the respective button in the settings popup

### Fiori Launchpad - Override Lunchmenu Language

* overrides language of the lunchmenu (home page tiles as well as app itself), so that you will see it e.g. in German even if your Fiori Launchpad is set to English
* this is no translation but depends on the lunchmenu being offered in the corresponding language
* currently supports `de` and `en` (define in settings popup / *Configuration*)

### SAP Jira - Count Tips

* show the ticket priority count and the unassigned count on the pagination
Expand All @@ -65,7 +58,7 @@ This is because of permissions and requires you to manually grant the correspond
## Configuration

At the bottom of the settings popup, you can navigate to *Configuration*.
Enter your email address (used for auto login on Sharepoint and Mural) and your preferred lunchmenu language (`de` / `en`; only if you want to override the default language) there.
Enter your email address (used for auto login on Sharepoint and Mural) there.
The data is auto-saved and only stored in your browser's local storage.

<img src="./screenshot-1.21-settings-popup-configuration.png" width="320" alt="Screenshot of Configuration in Popup" title="Screenshot of Configuration in Popup" />
Expand Down
6 changes: 2 additions & 4 deletions manifest-chrome.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"manifest_version": 3,
"name": "SAP Addon",
"version": "1.22.8",
"description": "Extension for SAP internal webpages: GitHub, Fiori Launchpad, Sharepoint, Jira",
"version": "1.22.10",
"description": "Extension for SAP internal webpages: GitHub, Sharepoint, Jira, ...",
"icons": {
"48": "icons/icon48.png",
"96": "icons/icon96.png",
Expand Down Expand Up @@ -46,11 +46,9 @@
],
"permissions": [
"storage",
"declarativeNetRequestWithHostAccess",
"scripting"
],
"host_permissions": [
"*://fiorilaunchpad.sap.com/sap/fiori/lunchmenu/*",
"*://github.wdf.sap.corp/*",
"*://github.tools.sap/*"
],
Expand Down
8 changes: 2 additions & 6 deletions manifest-fx.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"manifest_version": 2,
"name": "SAP Addon",
"version": "1.22.8",
"description": "Extension for SAP internal webpages: GitHub, Fiori Launchpad, Sharepoint, Jira",
"version": "1.22.10",
"description": "Extension for SAP internal webpages: GitHub, Sharepoint, Jira, ...",
"icons": {
"48": "icons/icon48.png",
"96": "icons/icon96.png",
Expand Down Expand Up @@ -46,9 +46,6 @@
],
"permissions": [
"storage",
"webRequest",
"webRequestBlocking",
"*://fiorilaunchpad.sap.com/sap/fiori/lunchmenu/*",
"*://github.wdf.sap.corp/*",
"*://github.tools.sap/*"
],
Expand All @@ -64,7 +61,6 @@
"utils/browser-setup.js",
"utils/storage.js",
"utils/option-helper.js",
"background_scripts/fx-fiori-lunchmenu.js",
"background_scripts/fx-on-tab-change.js",
"background_scripts/fetch-github-name.js",
"background_scripts/fx-message-listener.js",
Expand Down
16 changes: 0 additions & 16 deletions popup/popup.html
Original file line number Diff line number Diff line change
Expand Up @@ -49,18 +49,6 @@
<p></p>
</div>
</div>
<div class="section">
<p class="section-heading" title="fiorilaunchpad.sap.com">Fiori Launchpad</p>
<div class="section-text"
title="Sets the language of the lunchmenu to what you specify in the configuration regardless of your Fiori Launchpad settings">
<p>Override Lunchmenu Language</p>
<p><label class="switch">
<input type="checkbox" id="fiori-lunchmenu-german" checked>
<span class="slider round"></span>
</label></p>
<p></p>
</div>
</div>
<div class="section">
<p class="section-heading" title="Optional: jira.tools.sap (You may enable this first within 'Optional Permissions')">SAP Jira</p>
<div class="section-text disabled"
Expand Down Expand Up @@ -147,10 +135,6 @@
<p class="section-heading">Email Address <span title="Used to log in automatically (Sharepoint, Mural)"></span></p>
<p><input type="email" id="config-email" placeholder="your.email@sap.com" /></p>

<p class="section-heading">Lunchmenu Language <span title="Only applies if enabled in settings"></span></p>
<p><input type="text" id="config-lunchmenu-language" placeholder="de, en, ..." value="de"
pattern="^de|en$" title="de - German; en - English" /></p>

<p id="debug"></p>
</div>
<div class="section">
Expand Down
3 changes: 1 addition & 2 deletions popup/popup.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,14 @@ const inputIds = [
"github-sign-in",
"github-hide-notice-overlay",
"github-show-names",
"fiori-lunchmenu-german",
"sharepoint-login",
"stackenterprise-login",
"mural-login",
"pluralsight-login",
"jira-count-tips",
];
const buttonInputIds = ["github-hide-notice-show-all-again"];
const configInputIds = ["config-email", "config-lunchmenu-language"];
const configInputIds = ["config-email"];

let options = {};
let config = {};
Expand Down
6 changes: 3 additions & 3 deletions updates.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@
"update_link": "https://nikolockenvitz.github.io/sap-addon/xpi/sap_addon-1.21.5.xpi",
"update_hash": "sha256:ff9d1f692a7fb381320ba62577f37b52d47d1d2e98a2f159871a64bd220fc59a"
}, {
"version": "1.22.8",
"update_link": "https://nikolockenvitz.github.io/sap-addon/xpi/sap_addon-1.22.8.xpi",
"update_hash": "sha256:81e4e518aab429ec7953c4ffba0b4f43962b6bcfc9e05d5c507a4250b29b63a5"
"version": "1.22.10",
"update_link": "https://nikolockenvitz.github.io/sap-addon/xpi/sap_addon-1.22.10.xpi",
"update_hash": "sha256:34228c5fd132a3ade691434a43e112080ba040356b0688e5d10750ab076a2b9a"
}
]
}
Expand Down
Binary file not shown.

0 comments on commit 7e4e2af

Please sign in to comment.