Fix custom font-family's not loaded on text nodes #1724
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Looks for text nodes in an SVG and adds the font-family attribute whenever a font-family was added. This will make sure that custom fonts load properly on svg elements.
This PR fixes/implements the following bugs/features
Solves the issues listed above
Test plan (required)
Add a custom font with
@font-face
, use the custom font in a css class and add the class to a svg text elementCode formatting
Please make sure that code adheres to the project code formatting. Running
npm run format
will automatically format your code correctly.Closing issues
closes #1463, #1709