Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element scroll positions not preserved on clone #511

Closed
usmonster opened this issue Jan 20, 2015 · 7 comments
Closed

Element scroll positions not preserved on clone #511

usmonster opened this issue Jan 20, 2015 · 7 comments
Labels

Comments

@usmonster
Copy link
Contributor

This makes any overflowed elements that have been scrolled from their default positions appear incorrect (unscrolled) in the canvas:

http://jsfiddle.net/o0uco97c/

It's the Element analogue of the past issues with window scroll position (#57, #254, et al.), and it is a regression (working example using v0.4.1)

@tobya
Copy link

tobya commented Feb 23, 2015

Does anyone have any idea of what the workaround for this might be until it is fixed? I would even try to do a patch myself if someone pointed me in the right direction?

@niklasvh
Copy link
Owner

Should be fixed with 585a96a

@usmonster
Copy link
Contributor Author

Nice! Though looks like either the order or way of drawing text is a bit off here, since the ascender of the h can be seen in the current demo when it should be cut off/hidden: http://jsfiddle.net/o0uco97c/ (looks fine in v0.4.1).

@niklasvh
Copy link
Owner

That appears to be an issue with hiding overflown content

@niklasvh niklasvh reopened this Feb 28, 2015
@tobya
Copy link

tobya commented Mar 2, 2015

This seems to have fixed my related issue #542 anyway.

However while its fine for my use, it does seem to cause some confusion in the top portion of the captured div.

Before Update

clancy_3_cheese

After Update

clancy_4

as you can see the scroll is now preserved but it does some odd stuff with the header. I doesnt matter to me in this usecase but might cause other people issues.

@ejlocop
Copy link

ejlocop commented Apr 30, 2015

guys, im newbee here. i have a problem,
html2canvas only rendering what's visible on screen.
but what i want is to capture the whole scrolling div into canvas.
1
2

can someone help to resolve this? thank you

@usmonster
Copy link
Contributor Author

@niklasvh, is the remaining part of this bug the same as #349? If so, should this one be closed in favor of that one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants