Remove redundant style nodes from clone

niklasvh · Aug 18, 2017 · 5dbb197 · 5dbb197
1 parent bd463d9
commit 5dbb197
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/Clone.js b/src/Clone.js
@@ -93,7 +93,9 @@ export class DocumentCloner {
 
         for (let child = node.firstChild; child; child = child.nextSibling) {
             if (child.nodeType !== Node.ELEMENT_NODE || child.nodeName !== 'SCRIPT') {
-                clone.appendChild(this.cloneNode(child));
+                if (!this.copyStyles || child.nodeName !== 'STYLE') {
+                    clone.appendChild(this.cloneNode(child));
+                }
             }
         }
         if (node instanceof HTMLElement && clone instanceof HTMLElement) {

diff --git a/src/renderer/ForeignObjectRenderer.js b/src/renderer/ForeignObjectRenderer.js
@@ -44,6 +44,8 @@ export default class ForeignObjectRenderer {
                 resolve(this.canvas);
             };
 
+            img.onerror = reject;
+
             img.src = `data:image/svg+xml;charset=utf-8,${encodeURIComponent(
                 new XMLSerializer().serializeToString(svg)
             )}`;