Skip to content

Commit

Permalink
[analyzer][NFC] Rename GREngine->CoreEngine, GRExprEngine->ExprEngine…
Browse files Browse the repository at this point in the history
… in comments and txt files

fixes rust-lang#115
  • Loading branch information
Gabor Marton committed May 27, 2022
1 parent 7727d2a commit 6ab69ef
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion clang/lib/StaticAnalyzer/Core/ExprEngine.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
//===----------------------------------------------------------------------===//
//
// This file defines a meta-engine for path-sensitive dataflow analysis that
// is built on GREngine, but provides the boilerplate to execute transfer
// is built on CoreEngine, but provides the boilerplate to execute transfer
// functions and build the ExplodedGraph at the expression level.
//
//===----------------------------------------------------------------------===//
Expand Down
6 changes: 3 additions & 3 deletions clang/lib/StaticAnalyzer/README.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
= Library Structure =

The analyzer library has two layers: a (low-level) static analysis
engine (GRExprEngine.cpp and friends), and some static checkers
engine (ExprEngine.cpp and friends), and some static checkers
(*Checker.cpp). The latter are built on top of the former via the
Checker and CheckerVisitor interfaces (Checker.h and
CheckerVisitor.h). The Checker interface is designed to be minimal
Expand Down Expand Up @@ -58,7 +58,7 @@ ImmutableMaps) which share data between instances.

Finally, individual Checkers work by also manipulating the analysis
state. The analyzer engine talks to them via a visitor interface.
For example, the PreVisitCallExpr() method is called by GRExprEngine
For example, the PreVisitCallExpr() method is called by ExprEngine
to tell the Checker that we are about to analyze a CallExpr, and the
checker is asked to check for any preconditions that might not be
satisfied. The checker can do nothing, or it can generate a new
Expand Down Expand Up @@ -92,7 +92,7 @@ method call.
= Working on the Analyzer =

If you are interested in bringing up support for C++ expressions, the
best place to look is the visitation logic in GRExprEngine, which
best place to look is the visitation logic in ExprEngine, which
handles the simulation of individual expressions. There are plenty of
examples there of how other expressions are handled.

Expand Down
2 changes: 1 addition & 1 deletion clang/test/Analysis/PR3991.m
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ @implementation IHGoogleDocsAdapter - (id)initWithUsername:(NSString *)inUser
// Actual test case:
//
// The analyzer currently doesn't reason about ObjCKVCRefExpr. Have both
// GRExprEngine::Visit and GRExprEngine::VisitLValue have such expressions
// ExprEngine::Visit and ExprEngine::VisitLValue have such expressions
// evaluate to UnknownVal.
//===----------------------------------------------------------------------===//

Expand Down
4 changes: 2 additions & 2 deletions clang/test/Analysis/misc-ps-eager-assume.m
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ void handle_assign_of_condition(int x) {
// a symbolic value for this variable, but in the branch condition it is
// promoted to 'int'. Currently the analyzer doesn't reason well about
// promotions of symbolic values, so this test case tests the logic in
// 'recoverCastedSymbol()' (GRExprEngine.cpp) to test that we recover
// 'recoverCastedSymbol()' (ExprEngine.cpp) to test that we recover
// path-sensitivity and use the symbol for 'needsAnArray' in the branch
// condition.
//
Expand Down Expand Up @@ -128,7 +128,7 @@ void rdar7342806(void) {
// This test case depends on using -analyzer-config eagerly-assume=true and
// -analyzer-store=region. The 'eagerly-assume=true' causes the path
// to bifurcate when evaluating the function call argument, and a state
// caching bug in GRExprEngine::CheckerVisit (and friends) caused the store
// caching bug in ExprEngine::CheckerVisit (and friends) caused the store
// to 'p' to not be evaluated along one path, but then an autotransition caused
// the path to keep on propagating with 'p' still set to an undefined value.
// We would then get a bogus report of returning uninitialized memory.
Expand Down

0 comments on commit 6ab69ef

Please sign in to comment.