One more

nik9000 · Aug 25, 2023 · a7cbdbb · a7cbdbb
1 parent 73f5331
commit a7cbdbb
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 5 deletions.
diff --git a/docs/reference/esql/functions/abs.asciidoc b/docs/reference/esql/functions/abs.asciidoc
@@ -1,5 +1,8 @@
 [[esql-abs]]
 === `ABS`
+[.text-center]
+image::signature/abs.svg[]
+
 Returns the absolute value.
 
 [source,esql]
@@ -8,3 +11,7 @@ FROM employees
 | KEEP first_name, last_name, height
 | EVAL abs_height = ABS(0.0 - height)
 ----
+
+Supported types:
+
+include::types/abs.asciidoc[]
diff --git a/docs/reference/esql/functions/signature/abs.svg b/docs/reference/esql/functions/signature/abs.svg
diff --git a/docs/reference/esql/functions/types/abs.asciidoc b/docs/reference/esql/functions/types/abs.asciidoc
@@ -1,6 +1,6 @@
 [%header.monospaced.styled,format=dsv,separator=|]
 |===
-arg1 | result
+n | result
 double | double
 integer | integer
 long | long

diff --git a/x-pack/plugin/esql/qa/testFixtures/src/main/resources/show.csv-spec b/x-pack/plugin/esql/qa/testFixtures/src/main/resources/show.csv-spec
@@ -9,7 +9,7 @@ showFunctions
 show functions;
 
   name:keyword           |           synopsis:keyword
-abs                      |abs(arg1)
+abs                      |abs(n)
 acos                     |acos(arg1)
 asin                     |asin(arg1)
 atan                     |atan(arg1)

diff --git a/.../esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/math/Abs.java b/.../esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/math/Abs.java
@@ -11,6 +11,7 @@
 import org.elasticsearch.compute.operator.EvalOperator;
 import org.elasticsearch.xpack.esql.EsqlUnsupportedOperationException;
 import org.elasticsearch.xpack.esql.evaluator.mapper.EvaluatorMapper;
+import org.elasticsearch.xpack.esql.expression.function.Named;
 import org.elasticsearch.xpack.esql.expression.function.scalar.UnaryScalarFunction;
 import org.elasticsearch.xpack.ql.expression.Expression;
 import org.elasticsearch.xpack.ql.tree.NodeInfo;
@@ -22,8 +23,8 @@
 import java.util.function.Supplier;
 
 public class Abs extends UnaryScalarFunction implements EvaluatorMapper {
-    public Abs(Source source, Expression field) {
-        super(source, field);
+    public Abs(Source source, @Named("n") Expression n) {
+        super(source, n);
     }
 
     @Override