Add retry_on_conflict support to bulk api

Closes ruflin#623
nik9000 · Jun 2, 2014 · 0e3d20b · 0e3d20b
1 parent 78ddeb9
commit 0e3d20b
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 0 deletions.
diff --git a/changes.txt b/changes.txt
@@ -1,5 +1,8 @@
 CHANGES
 
+2014-06-02
+- add retry_on_conflict support to bulk #623
+
 2014-06-01
 - toString updated to consider doc_as_upsert if sent an array source #622
 

diff --git a/lib/Elastica/Bulk/Action/IndexDocument.php b/lib/Elastica/Bulk/Action/IndexDocument.php
@@ -42,6 +42,7 @@ protected function _getMetadataByDocument(Document $document)
             'parent',
             'ttl',
             'timestamp',
+            'retry_on_conflict',
         );
         $metadata = $document->getOptions($params, true);
 

diff --git a/test/lib/Elastica/Test/BulkTest.php b/test/lib/Elastica/Test/BulkTest.php
@@ -616,6 +616,25 @@ public function testGetPath()
         $this->assertEquals($indexName . '/' . $typeName . '/_bulk', $bulk->getPath());
     }
 
+    public function testRetry()
+    {
+        $index = $this->_createIndex();
+        $type = $index->getType('bulk_test');
+        $client = $index->getClient();
+
+        $doc1 = $type->createDocument(1, array('name' => 'Mister Fantastic'));
+        $doc1->setOpType(Action::OP_TYPE_UPDATE);
+        $doc1->setRetryOnConflict(5);
+
+        $bulk = new Bulk($client);
+        $bulk->addDocument($doc1);
+
+        $actions = $bulk->getActions();
+
+        $metadata = $actions[0]->getMetadata();
+        $this->assertEquals(5, $metadata[ '_retry_on_conflict' ]);
+    }
+
     public function udpDataProvider()
     {
         return array(