Skip to content

Commit

Permalink
Remove workaround for defining Jaeger sampling strategy
Browse files Browse the repository at this point in the history
jaegertracing/jaeger#3022 has been fixed in
Jaeger All-in-One 1.23

Signed-off-by: Kai Hudalla <kai.hudalla@bosch.io>
  • Loading branch information
sophokles73 committed Oct 1, 2021
1 parent 0a4b343 commit f8f90d8
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
2 changes: 1 addition & 1 deletion charts/hono/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ name: hono
description: |
Eclipse Hono™ provides remote service interfaces for connecting large numbers of IoT devices to a back end and
interacting with them in a uniform way regardless of the device communication protocol.
version: 1.10.2
version: 1.10.3
# Version of Hono being deployed by the chart
appVersion: 1.9.1
keywords:
Expand Down
3 changes: 0 additions & 3 deletions charts/hono/templates/jaeger/jaeger-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@ spec:
{{- end }}
{{- end }}
image: {{ .Values.jaegerBackendExample.allInOneImage }}
# the Dockerfile for the all-in-one container defines the "sampling.strategies-file" param in the CMD entry
# - this has to be overwritten here so that the SAMPLING_STRATEGIES_FILE env var value will be used instead (see https://github.com/jaegertracing/jaeger/issues/3022)
args: [""]
name: jaeger
ports:
- name: collector-grpc
Expand Down
2 changes: 1 addition & 1 deletion charts/hono/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ jaegerBackendExample:
enabled: false
# allInOneImage contains the name (including tag)
# of the container image to use for the example Jaeger back end.
allInOneImage: jaegertracing/all-in-one:1.22
allInOneImage: jaegertracing/all-in-one:1.26
# livenessProbeInitialDelaySeconds contains the value to use for the "initialDelaySeconds"
# configuration property of the component's liveness probe.
livenessProbeInitialDelaySeconds: 300
Expand Down

0 comments on commit f8f90d8

Please sign in to comment.