Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name too long, please switch back to BWP #3839

Merged
merged 1 commit into from
Aug 26, 2018

Conversation

viderehh
Copy link
Contributor

No description provided.

@PieterGit PieterGit added this to the 0.11.0 milestone Aug 20, 2018
@PieterGit
Copy link
Contributor

@viderehh This was changed by @lifeexcellence .

Can you (and perhaps other German translators like @herzogmedia and @schmitzn ) find consensus on whether or not this must be abbreviated or not?

@viderehh
Copy link
Contributor Author

in my case it takes to much space on my phone screen, and after a while i know whats behind bwp, iob,cob, etc...
in the english translation, the short name is also taken, so why dont do this for all!?
like to hear whats the other will say..
cheers

@PieterGit
Copy link
Contributor

I agree that sometimes a shorter name is ok. But I would like translators to agree. Please also change the base of this PR from master to dev. We only take changes to dev.

@herzogmedia
Copy link
Contributor

yeah, well, I can see the point. If we change it back, we should add the abbreviation back in the Menu-Button in parantheses, so it's easier to see where it is coming from. Also it would be nice to have the full name of every item in the tooltip. Would that be possible @PieterGit ?

@schmitzn
Copy link
Contributor

I'd also prefer the short form. And I really like the idea of @herzogmedia with the tooltip.

@PieterGit PieterGit merged commit 8a23db9 into nightscout:master Aug 26, 2018
@PieterGit
Copy link
Contributor

@cukibeza
Copy link

Merge pull request #3839 from viderehh/patch-1 German language change. Name too long, please switch back to BWP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants