update code comments on Node versions

thanks @jpcunningh #4155 (comment)
nightscout · Jan 1, 2019 · 878dd17 · 878dd17
1 parent 86a1c2f
commit 878dd17
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -131,7 +131,7 @@ Minimum browser requirements for viewing the site:
 
 Windows installation software requirements:
 
-- [Node.js](http://nodejs.org/) Latest Node 8 LTS (Node 8.15.0 or later) or Node 10 LTS (Node 10.14.1 or later). Use [Install instructions for Node](https://nodejs.org/en/download/package-manager/) or use `setup.sh`)
+- [Node.js](http://nodejs.org/) Latest Node 8 LTS (Node 8.15.0 or later) or Node 10 LTS (Node 10.15.0 or later; Node 10.14.1 works for Azure). Use [Install instructions for Node](https://nodejs.org/en/download/package-manager/) or use `setup.sh`)
 - [MongoDB](https://www.mongodb.com/download-center?jmp=nav#community) 3.x or later. MongoDB 2.4 is only supported for Raspberry Pi.
 
 As a non-root user clone this repo then install dependencies into the root of the project:

diff --git a/lib/server/bootevent.js b/lib/server/bootevent.js
@@ -7,13 +7,17 @@ var UPDATE_THROTTLE = 1000;
 function boot (env, language) {
 
   //////////////////////////////////////////////////
-  // Check Node version. Latest Node 8 LTS and Latest Node 10 LTS are recommended and supported.
+  // Check Node version. 
+  // Latest Node 8 LTS and Latest Node 10 LTS are recommended and supported. 
+  // Latest Node version on Azure is tolerated, but not recommended
+  // More explicit:
   // < 8        does not work, not supported
-  // >= 8.14.0  works, supported and recommended
-  // == 8.11.1  works, not fully supported (this is the latest Node version on Azure; INSECURE)
+  // >= 8.15.0  works, supported and recommended
   // == 9.x     does not work, not supported
-  // >= 10.14.2 works, supported and recommended
-  // >= 11.4.0  does not work, not recommended, will not be supported. We only support Node LTS releases
+  // == 10.14.1 works, not fully supported and not recommended (Azure version)
+  // == 10.14.2 does not work, not supported and not recommended, 
+  // >= 10.15.0 works, supported and recommended
+  // >= 11.6.0  does not work, not recommended, will not be supported. We only support Node LTS releases
   ///////////////////////////////////////////////////
   function checkNode (ctx, next) {
     var semver = require('semver');