Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse VOD chat direction when setting is enabled #5652

Merged
merged 2 commits into from
Oct 15, 2022

Conversation

MartijnWelker
Copy link
Contributor

Fixes #5612

@night
Copy link
Owner

night commented Oct 2, 2022

Thanks for the pull request. It doesn't appear to work properly. While the ordering is changed in the style level, new chat lines do not appear to populate in reverse order when playing the feed. In addition, scrolling in the opposite direction seems to pause chat replay.

@MartijnWelker
Copy link
Contributor Author

Ah good catch! I accidentally reverted a bit too much of my code I believe. I’ll fix it up tomorrow and re-request a review 🙂

@MartijnWelker
Copy link
Contributor Author

@night I've fixed the order of new chat messages appearing and the automatic scrolling.

I ran into a small issue with the scroll syncing where it would not properly stay synced to the top which I fixed by manually scrolling to the top of the container on every scroll event, but maybe you know a better way of handling this.

@night night merged commit 47e4083 into night:master Oct 15, 2022
night pushed a commit to maxwlang/betterttv-highlight-deleted that referenced this pull request Dec 26, 2022
dclstn pushed a commit to dclstn/betterttv that referenced this pull request Jan 3, 2023
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new pull request for related issues or feature requests.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2023
@MartijnWelker MartijnWelker deleted the 5612 branch October 5, 2023 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request - Reverse chat for VODs
2 participants