Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typescript Compilation #24

Merged
merged 8 commits into from
Mar 7, 2024
Merged

Conversation

nigelnindodev
Copy link
Owner

This PR adds Typescript compilation as a build step for every PR.

Closes #23

@nigelnindodev nigelnindodev added bug Something isn't working enhancement New feature or request labels Mar 7, 2024
@nigelnindodev nigelnindodev marked this pull request as ready for review March 7, 2024 13:55
@nigelnindodev nigelnindodev self-assigned this Mar 7, 2024
@nigelnindodev
Copy link
Owner Author

Still, one more 3rd party issue to resolve with https://github.com/elysiajs/elysia-cookie

Screenshot from 2024-03-07 18-35-45

We depend on the library, but it isn't defined as a d.ts file, hence the compiler thinks it's part of our source code.

@nigelnindodev
Copy link
Owner Author

nigelnindodev commented Mar 7, 2024

We'll merge this PR for now, and open up an issue with the library maintainers.

@nigelnindodev nigelnindodev merged commit 11d2865 into master Mar 7, 2024
1 check failed
@nigelnindodev nigelnindodev deleted the fix/fix-typescript-compilation branch March 7, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Typescript Compilation Build Steps
1 participant