Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser fails when there are multiple 'inflow' columns #45

Closed
nielsmaerten opened this issue Sep 1, 2022 · 3 comments · Fixed by #46
Closed

Parser fails when there are multiple 'inflow' columns #45

nielsmaerten opened this issue Sep 1, 2022 · 3 comments · Fixed by #46

Comments

@nielsmaerten
Copy link
Owner

From discussion #42:
The app is now giving me another error…

Unable to parse ''.
The expected date format was: 'dd/MM/yyyy'.
You may want to check the format in your config.yaml file.

The config.yaml is set like this:

[…]
header_rows: 10
footer_rows: 3
delimiter: ","
columns: [skip, skip, date, payee, inflow, inflow, skip]
date_format: dd/MM/yyyy
decimal_separator: "."
thousand_separator: ""
[…]

And the CSV is like this (added some xxxx for privacy reasons):

[…]
,Data contabile,Data valuta,Tipologia,Entrate,Uscite,Divisa
,,30/08/2022,POS-xxxxxxx,,-7.00,EUR
,,30/08/2022,POS-xxxxxxx,,-33.29,EUR
,,30/08/2022,POS-xxxxxxx,,-3.00,EUR
,,30/08/2022,POS-xxxxxxx,,-24.00,EUR
,01/09/2022,01/09/2022,Disposizione - RIF:xxxxxxx,,-180.00,EUR
,01/09/2022,31/08/2022,Addebito canone -xxxxxxx,,-1.00,EUR
[…]

Any clue? Should open a new issue?

Thanks again!
Bruno A. De Santis

@nielsmaerten nielsmaerten changed the title Unable to parse ''. Parser fails when there are multiple 'inflow' columns Sep 19, 2022
@nielsmaerten
Copy link
Owner Author

@justalittle-BIT
Hi Bruno,

So I got back from my vacation 😎, and had some time to look into your issue.
Turns out that having multiple 'inflow' columns might indeed be the problem.

I have again created a preview release that should now be able to handle your CSV files correctly.
Let me know if it works! :)

Greets,
Niels

@justalittle-BIT
Copy link

justalittle-BIT commented Sep 22, 2022 via email

@nielsmaerten
Copy link
Owner Author

Great! I'll merge the PR and get this rolled out to the main release then.

One question: do you think it would be feasible to make it crunch also xlsx files?

I do believe that's theoretically possible, but it's not something I have time to tackle right now. XLSX files can be tricky to parse because they can have multiple sheets, markup such as bold and italic text, macros, ...

Also AFAIK, there aren't many banks that offer transactions as an xlsx file, while not also offering csv. So it seems a little out of scope for ynab-buddy.

But hey, if you or anyone reading this wants to take a swing at it: go ahead and click that fork button :)

nielsmaerten added a commit that referenced this issue Sep 22, 2022
fix(45): proposed fix for issue #45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants