Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

Frontend: Localize URLS #155

Merged
merged 3 commits into from
Oct 23, 2021
Merged

Frontend: Localize URLS #155

merged 3 commits into from
Oct 23, 2021

Conversation

nielsmaerten
Copy link
Owner

@nielsmaerten nielsmaerten commented Oct 23, 2021

Description

This PR appends the full i18n code (en-US, es-ES, nl-NL, ...) to urls for FAQ, privacy and terms.
It also updates the 'contribute translations' url to https://pages.glucocheck.app/translations

Motivation and Context

  • Urls on the homepage should point to docs in the user's own language
  • Candidate translators used to be pointed to CrowdIn without any further explanation. Now they see a page explaining the process we follow when translating. This is just an attempt to communicate more clearly

How Has This Been Tested?

  • Tested on Nightly

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I've made my changes in a separate branch
  • My change is passing new and existing tests

@codecov
Copy link

codecov bot commented Oct 23, 2021

Codecov Report

Merging #155 (e3d1b7e) into main (d0436ec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files          52       52           
  Lines         959      959           
  Branches      192      192           
=======================================
  Hits          913      913           
  Misses         45       45           
  Partials        1        1           
Impacted Files Coverage Δ
gluco-check-frontend/src/App.tsx 100.00% <ø> (ø)
...luco-check-frontend/src/components/Boilerplate.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0436ec...e3d1b7e. Read the comment docs.

@nielsmaerten nielsmaerten merged commit 1594502 into main Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant