Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (googleTranlator) avoid translateBatch fails #12

Conversation

pasagedev
Copy link
Contributor

@pasagedev pasagedev commented Oct 31, 2021

This change do:

  • For translateBatch() on GoogleTranslator:

  • avoid fails if any element fails

  • array with same numbers of elements must be returned

  • errors must be captured and returned

  • pendent do the same on MymemoryTranslator

related issue: #11

@pasagedev pasagedev changed the title fix: (googleTranlator) avoid translateBash fails fix: (googleTranlator) avoid translateBatch fails Oct 31, 2021
@nidhaloff nidhaloff marked this pull request as ready for review November 2, 2021 16:14
@pasagedev pasagedev closed this Nov 3, 2021
@pasagedev pasagedev deleted the improve-translateBash-performance branch November 3, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant